Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PartitionSupervisor for ChainWriter #1039

Conversation

Neylix
Copy link
Member

@Neylix Neylix commented May 16, 2023

Description

Due to hot reload, using a DynamicSupervisor to start the 20 ChainWriter was'nt good, on hot reload the init function of the EmbeddedImpl.Supervisor was rerun a was creating again 20 ChainWriter.
Other issue was that if the DynamicSupervisor crash, the EmbeddedImpl.Supervisor crash also.

To fix this, we can use a ParitionSupervisor which is exactly what we want

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Start the node, everything works as expected

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Neylix Neylix added enhancements release Involve release / hot reload mecanism labels May 16, 2023
@Neylix Neylix force-pushed the Update-ChainWriterSupervisor branch from 010330a to 6462e18 Compare May 16, 2023 12:42
@samuelmanzanera samuelmanzanera merged commit 51c916d into archethic-foundation:1.1.0 May 16, 2023
@Neylix Neylix deleted the Update-ChainWriterSupervisor branch May 16, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancements release Involve release / hot reload mecanism
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants